Are preserved shiners in the jar effective at catching a variety of fish? If so, what fish and how. My dad always told me to never use them as the smell of the preservatives repellant fish.

Catfish, several species, that's "variety".

I've used preserved shad as bait for a "variety" of fish before and have had very little success, even with catfish. Fresh will work much better if you have the access.

Are preserved shiners in the jar effective at catching a variety of fish? If so, what fish and how. My dad always told me to never use them as the smell of the preservatives repellant fish.

That stuff sure is repellant...look what it did to them shiners. 

I hate auto correct, I meant the smell of the preservatives repells fish. Not repellent fish.