Mine would have to be a rat-l-trap I bought as a kid in the late 70's. It looks bad but still catches consistantly. It started life as chrome with black back, most of the paint is gone. What you got?

The most productive lure for me, old school or not, is hands down the worm. Edit: the straight tail finesse worm specifically.

Magnum UV Speed Worm and Rage Bug since they were first released. 
 

None before were as successful
 

 

 

 

 

 

 

Mike

 Just  finished putting new hooks on a Bomber Model A .Bomber lures are a long time favorite of mine.   Old Long A Minnows with a tail prop "Prop A" is my favorite top water behind a buzzbait. 

Blue-fleck power worm, 7". 

 

Been producing since the 1990's. 

 

A 7 1/2 inch Red Shad/Green Glitter worm. Been using this for over 40 years and it still produces in south Louisiana, especially the Atchafalaya Basin.

Spinnerbait 

Frog color Jitterbug.

Hard bait…. Rapala silver/ black back, plastics….  ribbon tail worm.

1 hour ago, DaubsNU1 said:

Blue-fleck power worm, 7". 

Been producing since the 1990s. 

I was very close to naming this one myself.  Pretty sure I still have a bulk supply in the bowels of my tackle room.

But instead, and since the worm is already represented, I am going with the vintage Rapala Minnow.

A-Jay

 

In line spinners.

Old time Bomber.  Photo is of some of the first fish I caught with it back in the 1970's.

Still works today crankin' standing timber.

I have 3 left.

A 6" Creme Scoundrel plastic worm.

All time hands down and old for me … I think mid-90s

I still have the OG. That one has some battle scars

 

EDIT

Honorable mention is the lowly 4” Grub single tail Texas style

I'm not an old timer but I am an avid spinnerbait fisherman which I feel is just an old-timey technqiue. As far as specific baits, probably a Black Power Worm. Been using them since I was a little kid. 

Not sure if it counts but give me a crappie jig any day of the week. I have some form of a 1/16th ounce jig or at least a bare jig head tied on to 1 or 2 combos all season.

@Eric 26 My number 1 fish catcher from 74-79 (crappie jig)

close behind is a black jitterbug & Bagley B2. Then came the Plastic worm in about 80..

Jig / buzzbait / trap / frog / worm / jerkbait / spinnerbait - tied on pretty much 365 days a year for me.

'Old timey' lure to me is pre 1980.  My pick is the Bagley B1 or B2. 

Culprit tequila shad worm. Been using one forever

Mine would be a plastic worm also. Straight tail 4" or 6".

Mine would definitely be the Acme Kastmaster spoon.  I don't actually have any old ones, but it's my understanding that the design goes back to the 40's.  The 3/8oz at 1 7/8" does a great job mimicking young of the year gizzard on my water during the late summer and is effective triggering offshore pelagic bass.

 

scott

Black 8" Mann's Jellyworm. I was shocked to actually see some in BPS last week, hadn't seen them in a store in forever. 

 

Hard baits, it would be either the old Wiggle Warts, or a not as old timey but still long DC'd Zell Pop. I've lost and found this bait twice and it has just been a fish catching machine for me throughout it's lifetime.

 

Rapala Floating Minnow.  I haven't used one in years but I had one a long time ago that was silver, gold and black. Fished it until the paint was gone and the hooks rusted. It caught just about anything. 

Culprit original 7.5 worm in the bluegill color. Unfortunately they don't make them anymore which really sucks cause I have like 5 left.